claudio4j commented on code in PR #5126:
URL: https://github.com/apache/camel-k/pull/5126#discussion_r1476002653
##########
pkg/apis/camel/v1/maven_types_support.go:
##########
@@ -24,7 +24,11 @@ import (
func (in *MavenArtifact) GetDependencyID() string {
switch {
case in.Version == "":
- return "mvn:" + in.GroupID + ":" + in.ArtifactID
+ if in.Classifier == "" {
+ return "mvn:" + in.GroupID + ":" + in.ArtifactID
+ } else {
+ return "mvn:" + in.GroupID + ":" + in.ArtifactID + ":"
+ in.Type + ":" + in.Classifier
Review Comment:
The definition of the full dependency is:
`<group>:<artifact>:<type>:<version>:<classifier>`
However the dependency regex and the other checkers were not handling the
`type` field, and I didn't want to spend too much time finding the right regex
to handle the type or the classifier in isolation, because doing so would
require to change the dependency spec to allow either
`<group>:<artifact>:<type>` or `<group>:<artifact>:<classifier>`, but the
`type` and `classifier` may be any word, so we would have to determine a way
to set both cases.
Then, the solution I found at this moment is if the `classifier` is set,
then the `type` is a required field.
I suggest to open a new issue to better investigate this particular issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
