claudio4j commented on code in PR #5126:
URL: https://github.com/apache/camel-k/pull/5126#discussion_r1474822411
##########
pkg/util/maven/maven_project_test.go:
##########
@@ -181,6 +181,17 @@ func TestParseGAVMvnNoVersion(t *testing.T) {
assert.Equal(t, dep.ArtifactID, "camel-core")
}
+func TestParseGAVMvnClassifierNoVersion(t *testing.T) {
+ dep, err := ParseGAV("org.apache.camel:camel-k-core:jar:custom")
Review Comment:
The only missing test case is group:artifact:classifier (no type, no
version), as the current regex grouping does some assumption, which don't
support the mentioned test case and I think it's not worth to spend much time
to change this regex to accommodate this particular use case.
We can add a requirement, if there is a classifier, then a type is also
required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
