dstandish commented on code in PR #62554:
URL: https://github.com/apache/airflow/pull/62554#discussion_r2896518271
##########
airflow-core/tests/integration/otel/test_otel.py:
##########
@@ -510,16 +508,12 @@ def get_parent_span_id(span):
nested = get_span_hierarchy()
assert nested == {
- "otel_test_dag": None,
- "task1": None,
- "task1_sub_span1": None,
- "task1_sub_span2": None,
- "task1_sub_span3": "task1_sub_span2",
- "task1_sub_span4": None,
- "task2": None,
+ "sub_span1": "task_run.task1",
+ "task_run.task1": "dag_run.otel_test_dag",
+ "dag_run.otel_test_dag": None,
Review Comment:
i simplified the test dag so that it just adds one subspan
i don't think adding more nested subpspans actually tests anything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
