xBis7 commented on code in PR #62554:
URL: https://github.com/apache/airflow/pull/62554#discussion_r2894971319
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -2328,18 +2092,12 @@ def _update_state(dag: SerializedDAG, dag_run: DagRun):
tags={},
extra_tags={"dag_id": dag.dag_id},
)
- if span.is_recording():
- span.add_event(
- name="schedule_delay",
- attributes={"dag_id": dag.dag_id, "schedule_delay":
str(schedule_delay)},
- )
Review Comment:
I think we can start fresh. With the current state of Airflow, all the spans
for the internal methods, seemed random.
Additionally, most of these spans were representing airflow operations that
were unrelated to active dag_runs.
We can emit 2 sets of detailed spans
1. linked to the internals of actually running a dag
3. linked to general airflow operations running in the background, like the
scheduler loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
