dstandish commented on code in PR #62554:
URL: https://github.com/apache/airflow/pull/62554#discussion_r2896532599
##########
task-sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -133,6 +134,32 @@
from airflow.sdk.exceptions import DagRunTriggerException
from airflow.sdk.types import OutletEventAccessorsProtocol
+log = structlog.get_logger("task")
+
+tracer = trace.get_tracer(__name__)
+
+
+@contextmanager
+def _make_task_span(msg: StartupDetails):
+ parent_context = (
+ TraceContextTextMapPropagator().extract(msg.ti.context_carrier) if
msg.ti.context_carrier else None
+ )
+ ti = msg.ti
+ span_name = f"task_run.{ti.task_id}"
Review Comment:
this i'm not sure about. personally, not being an OTEL master, i feel like
this is weird. why clobber together all the information into the name -- isn't
that what attributes are for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
