> -----Original Message----- > From: David Nalley [mailto:[email protected]] > Sent: Friday, November 09, 2012 1:28 PM > To: [email protected] > Subject: Re: [DISCUSS] All checkins must include unit testing > > > What I meant is how do we enforce it if everyone agrees to it. So this is > > for > two parts. > > > > 1. Do we all agree that external components should be mocked up and all > commits have unit tests. > > I agree with this sentiment. At the same time I would tend to have a > much higher level of expectation of a committer compared with a > > > 2. How do enforce it if we agree. > > While we don't have technical methods of enforcement at present, we do > have social. Code reviews (even after the fact), vetos, etc. We > already catch many things (license headers, etc) this way. If a unit > test isn't forthcoming, there's always a revert.
No the problem isn't if it has a unit test. It's the coverage of the unit test. I would like to get to a point where code review is really just looking at unit tests and see what it actually covered. Is there any way to use gerrit for all commits? --Alex
