> -----Original Message----- > From: Alex Huang [mailto:[email protected]] > Sent: Friday, November 09, 2012 12:16 PM > To: [email protected] > Subject: [DISCUSS] All checkins must include unit testing > > I like to revive this topic. I punted this in 4.0 because there's just no > infrastructure in place and there were a lot of users asking for a refresh of > the code line. > > I like to propose that starting now all commits must have unit tests and > commits can be rejected on the bases that it doesnot have the appropriate > unit testing. > > A unit test is a test that have no external components. What this means is > that it must be mocked. For example, the F5 API must be mocked up before > F5 element can be checked in. > > One particular problem is how do we enforce that? Today, all committers can > checkin any time they want. I'm told with gerrit for example, all commits are > actually held until it's been review. Should we setup infrastructure for > this?
What I meant is how do we enforce it if everyone agrees to it. So this is for two parts. 1. Do we all agree that external components should be mocked up and all commits have unit tests. 2. How do enforce it if we agree. --Alex
