Jamshid, Hope your testing is going ok. Based on your experience, do you see any additional test suites that would help to get max coverage for s3 implementation. The tests you are running give decent coverage but I would like to enhance coverage if there is an immediate need.
Thanks /Sudha -----Original Message----- From: Jamshid Afshar [mailto:nore...@reviews.apache.org] On Behalf Of Jamshid Afshar Sent: Wednesday, August 22, 2012 6:40 PM To: David Nalley; Edison Su; Ewan Mellor; Jamshid Afshar; cloudstack; Chiradeep Vittal; Eric Dey Subject: Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6473/ ----------------------------------------------------------- (Updated Aug. 23, 2012, 1:40 a.m.) Review request for cloudstack. Changes ------- Chiradeep, here are the diffs against current master. I also made some internal changes to S3CAStorBucketAdapter to support "domain" and "zeroconf" in configuration. Description ------- Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done. Add initial support for Caringo's CAStor object storage as the S3 backend. Similar to the s3-hdfs example. Now storage.root can specify "castor" followed by a list of IP addresses for the nodes in the CAStor cluster. S3 operations will then create and read buckets and objects in CAStor instead of a file system. Diffs (updated) ----- NOTICE 9c124ab awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION awsapi/src/com/cloud/bridge/model/SHost.java 758cbbf awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java c8ca2bd awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 deps/awsapi-lib/CAStorSDK.jar PRE-CREATION deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION Diff: https://reviews.apache.org/r/6473/diff/ Testing ------- Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation). Thanks, Jamshid Afshar
