----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6473/#review10312 -----------------------------------------------------------
awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java <https://reviews.apache.org/r/6473/#comment21834> Can you make sure your code follows these conventions: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java <https://reviews.apache.org/r/6473/#comment21838> This logic seems suspect: if the port is not specified or if only the port is specified. awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java <https://reviews.apache.org/r/6473/#comment21836> magic number? Make it a final awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java <https://reviews.apache.org/r/6473/#comment21839> This would be a ConfigurationException? awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java <https://reviews.apache.org/r/6473/#comment21841> Magic numbers should be constants and documented awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java <https://reviews.apache.org/r/6473/#comment21842> ConfigurationException? awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java <https://reviews.apache.org/r/6473/#comment21845> you should probably set file.deleteOnExit() Also, "file" is a bad variable name. Even tempFile is a better name awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java <https://reviews.apache.org/r/6473/#comment21843> You might leave temporary files around here. awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java <https://reviews.apache.org/r/6473/#comment21844> cant really progress after this error? awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java <https://reviews.apache.org/r/6473/#comment21847> UnsupportedOperation? awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java <https://reviews.apache.org/r/6473/#comment21850> Why would there be an exception here? And if there is, why isn't the operation failing (the code continues) - Chiradeep Vittal On Aug. 10, 2012, 11:47 p.m., Jamshid Afshar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6473/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2012, 11:47 p.m.) > > > Review request for cloudstack. > > > Description > ------- > > Below is the commit message. This is my first patch, let me know if I did > anything wrong or if e.g. using "storage.root" is not how configuring a new > storage backend should be done. > > Add initial support for Caringo's CAStor object storage as the S3 backend. > > Similar to the s3-hdfs example. Now storage.root can specify "castor" > followed by a list of IP addresses for the nodes in the CAStor > cluster. S3 operations will then create and read buckets and objects > in CAStor instead of a file system. > > > Diffs > ----- > > awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION > awsapi/src/com/cloud/bridge/model/SHost.java 874b095 > awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java > 7a36a4b > awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 > deps/awsapi-lib/CAStorSDK.jar PRE-CREATION > deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION > > Diff: https://reviews.apache.org/r/6473/diff/ > > > Testing > ------- > > Tested a boto script I believe we got from Chiradeep (localhost_test.py) that > creates buckets and streams, does a range read and delete. I will continue to > do more testing > (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation). > > > Thanks, > > Jamshid Afshar > >
