On Thu, Sep 6, 2012 at 12:54 PM, Chiradeep Vittal <chiradeep.vit...@citrix.com> wrote: > Sorry about that. I should have been more careful.
No worries! It's fixed in master. > On 9/6/12 8:37 AM, "Chip Childers" <chip.child...@sungard.com> wrote: > >>And actually, after looking at the commit, the licensing statement >>actually belongs in the LICENSE file and not the NOTICE file. >> >>On Thu, Sep 6, 2012 at 11:34 AM, Chip Childers >><chip.child...@sungard.com> wrote: >>> Hey all, >>> >>> Can I ask a favor, which is to not edit the NOTICE and LICENSE files >>>directly? >>> >>> I'm trying to keep things structured within the >>> tools/whisker/descriptor.xml file, so that the LICENSE and NOTICE are >>> generated from that structured data. >>> >>> I'll take a look at the change in the commit, and integrate it into >>> the descriptor.xml file shortly. >>> >>> -chip >>> >>> >>> On Thu, Sep 6, 2012 at 2:37 AM, Chiradeep Vittal <chirade...@gmail.com> >>>wrote: >>>> >>>> ----------------------------------------------------------- >>>> This is an automatically generated e-mail. To reply, visit: >>>> https://reviews.apache.org/r/6473/#review11086 >>>> ----------------------------------------------------------- >>>> >>>> Ship it! >>>> >>>> >>>> I committed this to master. I did not see JmDns in the pom.xml so I >>>>removed it from the NOTICE >>>> >>>> - Chiradeep Vittal >>>> >>>> >>>> On Sept. 6, 2012, 12:07 a.m., Jamshid Afshar wrote: >>>>> >>>>> ----------------------------------------------------------- >>>>> This is an automatically generated e-mail. To reply, visit: >>>>> https://reviews.apache.org/r/6473/ >>>>> ----------------------------------------------------------- >>>>> >>>>> (Updated Sept. 6, 2012, 12:07 a.m.) >>>>> >>>>> >>>>> Review request for cloudstack. >>>>> >>>>> >>>>> Description >>>>> ------- >>>>> >>>>> Below is the commit message. This is my first patch, let me know if I >>>>>did anything wrong or if e.g. using "storage.root" is not how >>>>>configuring a new storage backend should be done. >>>>> >>>>> Add initial support for Caringo's CAStor object storage as the S3 >>>>>backend. >>>>> >>>>> Similar to the s3-hdfs example. Now storage.root can specify "castor" >>>>> followed by a list of IP addresses for the nodes in the CAStor >>>>> cluster. S3 operations will then create and read buckets and objects >>>>> in CAStor instead of a file system. >>>>> >>>>> >>>>> Diffs >>>>> ----- >>>>> >>>>> NOTICE 9c124ab >>>>> awsapi/pom.xml 2909376 >>>>> awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java >>>>>PRE-CREATION >>>>> awsapi/src/com/cloud/bridge/model/SHost.java 4ed5b7e >>>>> >>>>>awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java >>>>>2f1791e >>>>> awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java a117d13 >>>>> >>>>> Diff: https://reviews.apache.org/r/6473/diff/ >>>>> >>>>> >>>>> Testing >>>>> ------- >>>>> >>>>> Tested a boto script I believe we got from Chiradeep >>>>>(localhost_test.py) that creates buckets and streams, does a range >>>>>read and delete. I will continue to do more testing >>>>>(http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+Clou >>>>>dStack+S3+Implementation). >>>>> >>>>> >>>>> Thanks, >>>>> >>>>> Jamshid Afshar >>>>> >>>>> >>>> > >
