----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6492/#review10565 -----------------------------------------------------------
deps/.classpath <https://reviews.apache.org/r/6492/#comment22666> Minor Comment: could name it in lower-case to be consistent with the other jars. plugins/network-elements/brocade/src/com/cloud/api/commands/DeleteBrocadeLoadBalancerCmd.java <https://reviews.apache.org/r/6492/#comment22668> You should use EVENT_EXTERNAL_LB_DEVICE_DELETE. I see how you could have ended up in this error. Current external loadbalancer's delete cmds also return the wrong delete event type. plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightForLbPredictorCmd.java <https://reviews.apache.org/r/6492/#comment22669> responseObject is wrong. It should be SuccessResponse? plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightForLbPredictorCmd.java <https://reviews.apache.org/r/6492/#comment22672> Weighted round-robin is present in almost every lodadbalaner. Better to support this in the core rather than in a plug-in. May be in assignToLoadBalancerRule extra-parameters have to be added for weights. plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java <https://reviews.apache.org/r/6492/#comment22598> The weights for a Vm are not getting stored in the db. How will the user know the weight set? PS: I am not sure on how are VOs written for plugins plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java <https://reviews.apache.org/r/6492/#comment22670> No null check is required for mandatory parameters. plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java <https://reviews.apache.org/r/6492/#comment22671> A Vm can participate in many networks you might want to pick the right IP, you can use the following function for finding the right one NicDao.findByInstanceIdAndNetworkIdIncludingRemoved(networkId, vmId); - Vijay Venkatachalam On Aug. 8, 2012, 11:31 p.m., Krishna Sadasivam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6492/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2012, 11:31 p.m.) > > > Review request for cloudstack. > > > Description > ------- > > This is the patch for adding Brocade plugin to enable Brocade LBs in > CloudStack. The plugin can support Lb service in advanced zone networking. > Lb services: > *Protocols: TCP/UDP > *Lb algorithms: roundrobin, leastconn, weighted, weightedroundrobin, weighted > round robin static, enhanced weighted, responsetime > *Sticky Session persistence using sticky port > > > Diffs > ----- > > build/build-cloud-plugins.xml a7a1f39 > build/build-cloud.xml b4d120f > build/developer.xml d52b682 > client/tomcatconf/brocadeloadbalancer_commands.properties.in PRE-CREATION > client/tomcatconf/components.xml.in da7617d > deps/.classpath 1376b4f > deps/cloud-BrocadeService.jar PRE-CREATION > plugins/network-elements/brocade/.classpath PRE-CREATION > plugins/network-elements/brocade/.project PRE-CREATION > plugins/network-elements/brocade/build.xml PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/api/commands/AddBrocadeLoadBalancerCmd.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/api/commands/ConfigureBrocadeLoadBalancerCmd.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/api/commands/DeleteBrocadeLoadBalancerCmd.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancerNetworksCmd.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancersCmd.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightCommand.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightForLbPredictorCmd.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/api/response/BrocadeLoadBalancerResponse.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeLoadBalancerElementService.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/network/resource/BrocadeADXResource.java > PRE-CREATION > plugins/network-elements/brocade/test/com/cloud/network/element/Base64.java > PRE-CREATION > > plugins/network-elements/brocade/test/com/cloud/network/element/BrocadePluginTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/6492/diff/ > > > Testing > ------- > > Unit tests, Rest API calls from Rest client code > > > Thanks, > > Krishna Sadasivam > >
