----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6492/#review10534 -----------------------------------------------------------
plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java <https://reviews.apache.org/r/6492/#comment22550> account ID and network ID are not being used. Can it be removed from API? plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java <https://reviews.apache.org/r/6492/#comment22548> What happens if Vm id is invalid? Should throw an invalid parameter exception. plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java <https://reviews.apache.org/r/6492/#comment22549> error message is wrong, function is setting weight not applying load balancer rules plugins/network-elements/brocade/src/com/cloud/network/resource/BrocadeADXResource.java <https://reviews.apache.org/r/6492/#comment22551> what happens if vlan already exists. There is no transaction like behavior, so if in the middle of sequence of steps, if an API fails, then configuration changes are rolled back. In such cases, it better to be resilient. - Murali Reddy On Aug. 8, 2012, 11:31 p.m., Krishna Sadasivam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6492/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2012, 11:31 p.m.) > > > Review request for cloudstack. > > > Description > ------- > > This is the patch for adding Brocade plugin to enable Brocade LBs in > CloudStack. The plugin can support Lb service in advanced zone networking. > Lb services: > *Protocols: TCP/UDP > *Lb algorithms: roundrobin, leastconn, weighted, weightedroundrobin, weighted > round robin static, enhanced weighted, responsetime > *Sticky Session persistence using sticky port > > > Diffs > ----- > > build/build-cloud-plugins.xml a7a1f39 > build/build-cloud.xml b4d120f > build/developer.xml d52b682 > client/tomcatconf/brocadeloadbalancer_commands.properties.in PRE-CREATION > client/tomcatconf/components.xml.in da7617d > deps/.classpath 1376b4f > deps/cloud-BrocadeService.jar PRE-CREATION > plugins/network-elements/brocade/.classpath PRE-CREATION > plugins/network-elements/brocade/.project PRE-CREATION > plugins/network-elements/brocade/build.xml PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/api/commands/AddBrocadeLoadBalancerCmd.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/api/commands/ConfigureBrocadeLoadBalancerCmd.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/api/commands/DeleteBrocadeLoadBalancerCmd.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancerNetworksCmd.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancersCmd.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightCommand.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightForLbPredictorCmd.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/api/response/BrocadeLoadBalancerResponse.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeLoadBalancerElementService.java > PRE-CREATION > > plugins/network-elements/brocade/src/com/cloud/network/resource/BrocadeADXResource.java > PRE-CREATION > plugins/network-elements/brocade/test/com/cloud/network/element/Base64.java > PRE-CREATION > > plugins/network-elements/brocade/test/com/cloud/network/element/BrocadePluginTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/6492/diff/ > > > Testing > ------- > > Unit tests, Rest API calls from Rest client code > > > Thanks, > > Krishna Sadasivam > >
