Thanks for submitting patch. I took a quick look at the patch in general things look good. It would be better if you can give quick context on the ADX capabilities for better deatiled review. Some question I had was does ADX has a virtual appliance? NAT capabilities? Also where do you want to position Brocade ADX as LB provider in advanced zone only or both advanced and basic zones? I see that you implemented static NAT commands also, do you intend that with this patch Brocade SDX can be EIP provider in basic zone? I think currently EIP is hard coded to be provided by NetScaler devices, so you might want to relax that restriction for ADX to be EIP provider.
You may be aware, but just wanted to let you know. CloudStack has support for notion of pool of load balancer that can cloud-operator provision into a zone, so there could more than one ADX device in a physical network with the ability to offer a dedicated/shared load balancers based on the network offering. So please call out what patch is supporting. Let me know if you need any further details. On 09/08/12 5:01 AM, "Krishna Sadasivam" <ksada...@brocade.com> wrote: > >----------------------------------------------------------- >This is an automatically generated e-mail. To reply, visit: >https://reviews.apache.org/r/6492/ >----------------------------------------------------------- > >Review request for cloudstack. > > >Description >------- > >This is the patch for adding Brocade plugin to enable Brocade LBs in >CloudStack. The plugin can support Lb service in advanced zone networking. >Lb services: >*Protocols: TCP/UDP >*Lb algorithms: roundrobin, leastconn, weighted, weightedroundrobin, >weighted round robin static, enhanced weighted, responsetime >*Sticky Session persistence using sticky port > > >Diffs >----- > > build/build-cloud-plugins.xml a7a1f39 > build/build-cloud.xml b4d120f > build/developer.xml d52b682 > client/tomcatconf/brocadeloadbalancer_commands.properties.in >PRE-CREATION > client/tomcatconf/components.xml.in da7617d > deps/.classpath 1376b4f > deps/cloud-BrocadeService.jar PRE-CREATION > plugins/network-elements/brocade/.classpath PRE-CREATION > plugins/network-elements/brocade/.project PRE-CREATION > plugins/network-elements/brocade/build.xml PRE-CREATION > >plugins/network-elements/brocade/src/com/cloud/api/commands/AddBrocadeLoad >BalancerCmd.java PRE-CREATION > >plugins/network-elements/brocade/src/com/cloud/api/commands/ConfigureBroca >deLoadBalancerCmd.java PRE-CREATION > >plugins/network-elements/brocade/src/com/cloud/api/commands/DeleteBrocadeL >oadBalancerCmd.java PRE-CREATION > >plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoa >dBalancerNetworksCmd.java PRE-CREATION > >plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoa >dBalancersCmd.java PRE-CREATION > >plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightCom >mand.java PRE-CREATION > >plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightFor >LbPredictorCmd.java PRE-CREATION > >plugins/network-elements/brocade/src/com/cloud/api/response/BrocadeLoadBal >ancerResponse.java PRE-CREATION > >plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElem >ent.java PRE-CREATION > >plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeLoad >BalancerElementService.java PRE-CREATION > >plugins/network-elements/brocade/src/com/cloud/network/resource/BrocadeADX >Resource.java PRE-CREATION > >plugins/network-elements/brocade/test/com/cloud/network/element/Base64.jav >a PRE-CREATION > >plugins/network-elements/brocade/test/com/cloud/network/element/BrocadePlu >ginTest.java PRE-CREATION > >Diff: https://reviews.apache.org/r/6492/diff/ > > >Testing >------- > >Unit tests, Rest API calls from Rest client code > > >Thanks, > >Krishna Sadasivam > >
