Hi Ewan,
I have asked the concerned people in Brocade to respond to the licensing
issues. I will get back to you soon.
Thanks,
Krishna
-----Original Message-----
From: Ewan Mellor [mailto:ewan.mel...@eu.citrix.com]
Sent: Thursday, August 09, 2012 4:29 PM
To: cloudstack-dev@incubator.apache.org
Subject: RE: Review Request: Plugin for enabling Brocade as external load
balancing service provider in CloudStack
Hi Krishna,
First of all, thanks for the patch! It's great to see Brocade getting involved
in CloudStack, and I hope that you will be able to do more in the future too.
I don't know if you know this, but we're trying to get a CloudStack 4.0 release
together in the next month. The deadline for feature freeze is rapidly
approaching, so for your patch to get in, we'd have to get these license issues
resolved very soon (like, in a day or two).
If there is going to be any delay figuring out the licensing on
cloud-BrocadeService.jar, would it be a problem if this patch didn't get into
CloudStack 4.0? If that's OK, it would go immediately on the list for 4.1
instead. That would give you time to sort out what you want to do here.
As general guidance:
The easiest thing to do is to license your code under the Apache license, or a
compatible one such as BSD. This will mean that we can have the default
CloudStack build include support for your LBs, which is obviously a big win.
The Apache Foundation won't allow code that requires proprietary libraries in
the default configuration, so if you can't do this, then the feature would have
to be off by default. This isn't the end of the world, but it means that users
would have to recompile CloudStack from source to enable your software. This
would be the case if that jar is only available to Brocade customers or
otherwise not freely distributable. We're going to have to turn off NetApp
support in the default build for this reason, to give you an example.
Please let me know what you're planning to do at this point, so that we can
finalize the upcoming release.
Thanks,
Ewan.
> -----Original Message-----
> From: Krishna Sadasivam [mailto:ksada...@brocade.com]
> Sent: Wednesday, August 08, 2012 5:30 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: Review Request: Plugin for enabling Brocade as external
> load balancing service provider in CloudStack
>
> I am not sure about the license. This is the first time I am
> submitting code to open source. Let me get back to you on the license
> and the link for the jar.
>
> Thanks,
> Krishna
>
> -----Original Message-----
> From: David Nalley [mailto:da...@gnsa.us]
> Sent: Wednesday, August 08, 2012 5:16 PM
> To: Krishna Sadasivam
> Cc: cloudstack-dev@incubator.apache.org
> Subject: Re: Review Request: Plugin for enabling Brocade as external
> load balancing service provider in CloudStack
>
> What license is it released under?
> We need to likely set it up so that the jar can be downloaded
> automagically, but isn't included in the repo by default.
> If we were to set ant, ivy, gradle, or maven to do this in an
> automated fashion, where would we acquire the jar from?
>
> --David
>
> On Wed, Aug 8, 2012 at 8:12 PM, Krishna Sadasivam
> <ksada...@brocade.com> wrote:
> > Hi David,
> > cloud-BrocadeService.jar enables communication with Brocade load
> balancers. It won't be under Apache License. Can I send the jar as an
> attachment for now?
> >
> > Krishna
> >
> > -----Original Message-----
> > From: David Nalley [mailto:nore...@reviews.apache.org] On Behalf Of
> > David Nalley
> > Sent: Wednesday, August 08, 2012 5:01 PM
> > To: cloudstack; David Nalley; Krishna Sadasivam
> > Subject: Re: Review Request: Plugin for enabling Brocade as external
> > load balancing service provider in CloudStack
> >
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/6492/#review10050
> > -----------------------------------------------------------
> >
> >
> > Where does this file come from: deps/cloud-BrocadeService.jar
> >
> > What is it licensed under?
> > Link?
> >
> > --David
> >
> > - David Nalley
> >
> >
> > On Aug. 8, 2012, 11:31 p.m., Krishna Sadasivam wrote:
> >>
> >> -----------------------------------------------------------
> >> This is an automatically generated e-mail. To reply, visit:
> >> https://reviews.apache.org/r/6492/
> >> -----------------------------------------------------------
> >>
> >> (Updated Aug. 8, 2012, 11:31 p.m.)
> >>
> >>
> >> Review request for cloudstack.
> >>
> >>
> >> Description
> >> -------
> >>
> >> This is the patch for adding Brocade plugin to enable Brocade LBs
> >> in
> CloudStack. The plugin can support Lb service in advanced zone
> networking.
> >> Lb services:
> >> *Protocols: TCP/UDP
> >> *Lb algorithms: roundrobin, leastconn, weighted,
> >> weightedroundrobin, weighted round robin static, enhanced weighted,
> >> responsetime *Sticky Session persistence using sticky port
> >>
> >>
> >> Diffs
> >> -----
> >>
> >> build/build-cloud-plugins.xml a7a1f39
> >> build/build-cloud.xml b4d120f
> >> build/developer.xml d52b682
> >> client/tomcatconf/brocadeloadbalancer_commands.properties.in PRE-
> CREATION
> >> client/tomcatconf/components.xml.in da7617d
> >> deps/.classpath 1376b4f
> >> deps/cloud-BrocadeService.jar PRE-CREATION
> >> plugins/network-elements/brocade/.classpath PRE-CREATION
> >> plugins/network-elements/brocade/.project PRE-CREATION
> >> plugins/network-elements/brocade/build.xml PRE-CREATION
> >> plugins/network-
> elements/brocade/src/com/cloud/api/commands/AddBrocadeLoadBalancerCmd.
> j
> ava PRE-CREATION
> >> plugins/network-
> elements/brocade/src/com/cloud/api/commands/ConfigureBrocadeLoadBalanc
> e
> rCmd.java PRE-CREATION
> >> plugins/network-
> elements/brocade/src/com/cloud/api/commands/DeleteBrocadeLoadBalancerC
> m
> d.java PRE-CREATION
> >> plugins/network-
> elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancerNet
> w
> orksCmd.java PRE-CREATION
> >> plugins/network-
> elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancersCm
> d
> .java PRE-CREATION
> >> plugins/network-
> elements/brocade/src/com/cloud/api/commands/SetVmWeightCommand.java
> PRE-CREATION
> >> plugins/network-
> elements/brocade/src/com/cloud/api/commands/SetVmWeightForLbPredictorC
> m
> d.java PRE-CREATION
> >> plugins/network-
> elements/brocade/src/com/cloud/api/response/BrocadeLoadBalancerRespons
> e
> .java PRE-CREATION
> >> plugins/network-
> elements/brocade/src/com/cloud/network/element/BrocadeElement.java
> PRE- CREATION
> >> plugins/network-
> elements/brocade/src/com/cloud/network/element/BrocadeLoadBalancerElem
> e
> ntService.java PRE-CREATION
> >> plugins/network-
> elements/brocade/src/com/cloud/network/resource/BrocadeADXResource.jav
> a
> PRE-CREATION
> >>
> >> plugins/network-
> elements/brocade/test/com/cloud/network/element/Base6
> >> 4.java PRE-CREATION
> >>
> >> plugins/network-
> elements/brocade/test/com/cloud/network/element/Broca
> >> d
> >> ePluginTest.java PRE-CREATION
> >>
> >> Diff: https://reviews.apache.org/r/6492/diff/
> >>
> >>
> >> Testing
> >> -------
> >>
> >> Unit tests, Rest API calls from Rest client code
> >>
> >>
> >> Thanks,
> >>
> >> Krishna Sadasivam
> >>
> >>
> >
