> On Aug. 6, 2012, 9:34 a.m., Wido den Hollander wrote: > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java, > > line 124 > > <https://reviews.apache.org/r/6285/diff/4/?file=134275#file134275line124> > > > > The general rule on Linux is still to limit interface names to 12 > > characters. > > > > CloudVirBr is already 10 characters, so with 4 characters for the VLAN > > number you get to 14. > > > > Maybe change to cVirBr<id> ? > > Tomoe Sugihara wrote: > Hi Wido, > > Thanks for the comment:) > Actually this is from legacy code and I think IF name can go up to 15 > chars: > > > http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=blob;f=include/linux/if.h;h=f995c663c493baf4d369bcf05d3bed20d38dcd1f;hb=HEAD#l26
Ah, that is indeed legacy. This should be fine then since VLAN numbers can't exceed 4 digits. - Wido ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6285/#review9882 ----------------------------------------------------------- On Aug. 6, 2012, 1:39 a.m., Tomoe Sugihara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6285/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2012, 1:39 a.m.) > > > Review request for cloudstack, edison su and Chiradeep Vittal. > > > Description > ------- > > Add BridgeVifDriver and move current vif implementation to it. > > - remove dependency on VirtualRoutingResource. > - factor out some of the networking code in LibvirtComputingResource > to BridgeVifDriver. > > Add base class for KVM VifDriver. > > > Add VifDriver Interface for KVM. > > > Diffs > ----- > > > core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java > 33e297187fd7deaa6f6f975a115ff3c4c80f6794 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java > PRE-CREATION > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > 73101a9896c4863bc75502ff8b0b6daceff52dc4 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/VifDriver.java > PRE-CREATION > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/VifDriverBase.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/6285/diff/ > > > Testing > ------- > > Manually tested launching VM on all-in-one KVM box with Advanced networking. > > > Thanks, > > Tomoe Sugihara > >
