> -----Original Message----- > From: David Nalley [mailto:[email protected]] > Sent: Wednesday, August 01, 2012 5:00 PM > To: [email protected]; Saksham Srivastava > Cc: Edison Su > Subject: Re: Review Request: Removing obsolete JUnit test file and > disabling calls to cleanup.sql from upgrade tests. > > On Wed, Aug 1, 2012 at 7:58 PM, Saksham Srivastava > <[email protected]> wrote: > > > > > >> On Aug. 1, 2012, 11:29 p.m., edison su wrote: > >> > Could you use the following to skip upgrade test cases? > >> > diff --git a/build/developer.xml b/build/developer.xml > >> > index bfe496d..4e4a5aa 100755 > >> > --- a/build/developer.xml > >> > +++ b/build/developer.xml > >> > @@ -325,6 +325,7 @@ > >> > </fileset> > >> > <fileset dir="${server.test.dir}"> > >> > <include name="**/*Test.java"/> > >> > + <exclude name="**/upgrade/*.java"/> > >> > </fileset> > >> > </batchtest> > >> > </junit> > > > > People might want to add new upgrade related test cases, but doing > <exclude name="**/upgrade/*.java"/> will skip all the upgrade tests. > > If all the tests in the upgrade folder are obsolete and can be > skipped, then removing them would be a better choice. > > > > > That's probably worthy of it's own thread around what we want to > permit upgrades from.
It's not just a case of which upgrades to permit (though that's a worthy conversation). In this case, the tests no longer pass. I thought the assessment was that it was the tests that were broken rather than the code, which is why they were removed. Ewan.
