> On Aug. 1, 2012, 11:29 p.m., edison su wrote:
> > Could you use the following to skip upgrade test cases?
> > diff --git a/build/developer.xml b/build/developer.xml
> > index bfe496d..4e4a5aa 100755
> > --- a/build/developer.xml
> > +++ b/build/developer.xml
> > @@ -325,6 +325,7 @@
> > </fileset>
> > <fileset dir="${server.test.dir}">
> > <include name="**/*Test.java"/>
> > + <exclude name="**/upgrade/*.java"/>
> > </fileset>
> > </batchtest>
> > </junit>
People might want to add new upgrade related test cases, but doing <exclude
name="**/upgrade/*.java"/> will skip all the upgrade tests.
If all the tests in the upgrade folder are obsolete and can be skipped, then
removing them would be a better choice.
- Saksham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6283/#review9729
-----------------------------------------------------------
On Aug. 1, 2012, 3:40 p.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6283/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2012, 3:40 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Removed obsolete file SearchCriteria2Test.java which caused ant unittest to
> fail.
> cleanup.sql cleans up CLOUD and CLOUD_USAGE databases which are required by
> many unit-testcases.
>
>
> Diffs
> -----
>
> server/test/com/cloud/agent/manager/SearchCriteria2Test.java 763c548
> server/test/com/cloud/upgrade/AdvanceZone217To224UpgradeTest.java 27b2a7b
> server/test/com/cloud/upgrade/BasicZone218To224UpgradeTest.java 521e92a
> server/test/com/cloud/upgrade/HostCapacity218to22Test.java af6321a
> server/test/com/cloud/upgrade/InstanceGroup218To224UpgradeTest.java 601b1e8
> server/test/com/cloud/upgrade/PortForwarding218To224UpgradeTest.java
> a430584
> server/test/com/cloud/upgrade/Sanity220To224UpgradeTest.java ef47aad
> server/test/com/cloud/upgrade/Sanity222To224UpgradeTest.java aa30df2
> server/test/com/cloud/upgrade/Sanity224To225UpgradeTest.java a7b6ba1
> server/test/com/cloud/upgrade/Template2214To30UpgradeTest.java e7a01e3
> server/test/com/cloud/upgrade/Test2214To30DBUpgrade.java 5f05ac3
> server/test/com/cloud/upgrade/Usage217To224UpgradeTest.java d349247
> server/test/com/cloud/upgrade/UsageEvents218To224UpgradeTest.java 7319afa
>
> Diff: https://reviews.apache.org/r/6283/diff/
>
>
> Testing
> -------
>
> Verified the changes locally.
>
>
> Thanks,
>
> Saksham Srivastava
>
>