Can someone please review this request from Saksham? Our unit tests (http://jenkins.cloudstack.org/job/junit-test/) are currently showing 60 failures, and I'd like to get that number down so that we can see the real situation.
Thanks, Ewan. > -----Original Message----- > From: Saksham Srivastava [mailto:[email protected]] On Behalf > Of Saksham Srivastava > Sent: Wednesday, August 01, 2012 8:41 AM > To: Saksham Srivastava; cloudstack > Subject: Review Request: Removing obsolete JUnit test file and > disabling calls to cleanup.sql from upgrade tests. > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6283/ > ----------------------------------------------------------- > > Review request for cloudstack. > > > Summary (updated) > ----------------- > > Removing obsolete JUnit test file and disabling calls to cleanup.sql > from upgrade tests. > > > Description (updated) > ------- > > Removed obsolete file SearchCriteria2Test.java which caused ant > unittest to fail. > cleanup.sql cleans up CLOUD and CLOUD_USAGE databases which are > required by many unit-testcases. > > > Diffs (updated) > ----- > > server/test/com/cloud/agent/manager/SearchCriteria2Test.java 763c548 > server/test/com/cloud/upgrade/AdvanceZone217To224UpgradeTest.java > 27b2a7b > server/test/com/cloud/upgrade/BasicZone218To224UpgradeTest.java > 521e92a > server/test/com/cloud/upgrade/HostCapacity218to22Test.java af6321a > server/test/com/cloud/upgrade/InstanceGroup218To224UpgradeTest.java > 601b1e8 > server/test/com/cloud/upgrade/PortForwarding218To224UpgradeTest.java > a430584 > server/test/com/cloud/upgrade/Sanity220To224UpgradeTest.java ef47aad > server/test/com/cloud/upgrade/Sanity222To224UpgradeTest.java aa30df2 > server/test/com/cloud/upgrade/Sanity224To225UpgradeTest.java a7b6ba1 > server/test/com/cloud/upgrade/Template2214To30UpgradeTest.java > e7a01e3 > server/test/com/cloud/upgrade/Test2214To30DBUpgrade.java 5f05ac3 > server/test/com/cloud/upgrade/Usage217To224UpgradeTest.java d349247 > server/test/com/cloud/upgrade/UsageEvents218To224UpgradeTest.java > 7319afa > > Diff: https://reviews.apache.org/r/6283/diff/ > > > Testing (updated) > ------- > > Verified the changes locally. > > > Thanks, > > Saksham Srivastava
