On Monday, September 22, 2014 2:45:23 PM UTC-4, J David Eisenberg wrote:
>
> The good news: the code works. The bad news: I'm convinced I'm doing it
> wrong, in the moral purity sense of the word. Something inside of me says,
> "You could have just used (map...) to do this the *right* way," but I can't
> see how to do it with (map). {snip}
>
General comment: It's my hope that we don't cause anyone to fret that their
code doesn't meet some arbitrary standard of moral purity. :)
Your code looks ok, and others here have posted some great tips on making
it even better. (I really like how the Clojure community is almost always
willing to offer alternative elegant solutions!)
Here's some tidbits from me:
* use `(:require [clojure.string :as str])` in your file's `ns` macro so
you can write "str/replace" instead of the longer "clojure.string/replace"
* no need to pass an empty list to days-number-maker, since you can just
start yourself off with one in there inside a `let`.
BTW, you might enjoy Batsov's [Clojure Style
Guide](https://github.com/bbatsov/clojure-style-guide).
-- John
--
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
---
You received this message because you are subscribed to the Google Groups
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
