When I first wrote this code, I intentionally avoided any custom syntactical sugar and worked as closely with the primitives as I could.
After a few days away, I've used fresh eyes to abstract and revamp. The new code is *dramatically* cleaner and I only needed to introduce a few simple and predictable macros. With regards to my prior feedback: > 1) The (let [c chan] (go ...) c) pattern is *extremely-common*. Might be nice to have something like (go-as c ...) that expands to that pattern. I've implemented go-as without buffer parameterization. This was a huge cleanup. > 2) It's somewhat annoying to always have to consider boolean false all the time. I've introduced two macros: if-recv and when-recv. (if-recv [x p] ...) is equivalent to (let [x (<! p)] (if-not (nil? x) ...)) and when-recv does what you'd expect. Currently, these macros only operate on a single port to read from. I need to give this a bit more thought before I attempt a multiplexing version of this macro. > 3) Not mentioned in my prior feedback: Looping receives over a channel is pretty common too. For that, I've got the (dorecv [x port] ...) macro, which is analogous to doseq, but reads from port via <! Similarly, a multiplexing variant of dorecv needs more thought before I attempt that. I think you'll agree that the new code is much nicer looking: https://github.com/brandonbloom/asyncx/blob/89fe35eae8be9a3350855bf841fc11c46ea04b0f/src/asyncx/core.clj (doc strings available for these new macros too) Each one of these primitives is about an order of magnitude more useful than any of the original Rx operators... So I guess that means I can consider this a successful learning experience! In fact, I think these 4 macros might even be useful enough for the core.async namespace after some more field testing. Please let me know if these are helpful to you. I'd also love to know if there are any little patterns or macros like these that you've "discovered". Cheers, Brandon -- -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en --- You received this message because you are subscribed to the Google Groups "Clojure" group. To unsubscribe from this group and stop receiving emails from it, send an email to clojure+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
