Hi, I've created that ticked and the initial implementation. Currently I don't have a spare time to prepare a jsperf test, sorry for that.
In the ClojureScript, the performance gain is by skiping fromArray (directly create instance instead) and nth (in destructuring, directly access underlying array) calls. While the current persistent vector creation and destructuring is quite fast, if you use vectors for passing multiple values in or out of the functions, these operations quickly add up into a considerable amount. Best, JW On Sunday, January 20, 2013 9:17:47 PM UTC+1, Philip Potter wrote: > > I second this. Optimizations should be backed by evidence. > > Further, the tail in PersistentVector seems to serve a similar role, at a > high level, as ArrayMap does for maps, so it would be slightly surprising > to me if this would have much effect. > > Phil > On Jan 20, 2013 8:07 PM, "David Nolen" <dnolen...@gmail.com <javascript:>> > wrote: > >> I think we would need to see more comprehensive benchmarks before we can >> come to any conclusions. >> >> >> On Sun, Jan 20, 2013 at 2:03 PM, Jim - FooBar(); >> <jimpi...@gmail.com<javascript:> >> > wrote: >> >>> I've recently noticed this: http://dev.clojure.org/jira/browse/CLJS-453 >>> >>> It is for cljs but it makes sense right? >>> We do have them for maps - how hard can it be to make them for small >>> vectors as well? In fact I'm surprised we don't have them already but >>> perhaps I'm missing crucial details... destructuring would be super-fast >>> yes? >>> >>> Jim >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Clojure" group. >>> To post to this group, send email to clo...@googlegroups.com<javascript:> >>> Note that posts from new members are moderated - please be patient with >>> your first post. >>> To unsubscribe from this group, send email to >>> clojure+u...@googlegroups.com <javascript:> >>> For more options, visit this group at >>> http://groups.google.com/group/clojure?hl=en >> >> >> -- >> You received this message because you are subscribed to the Google >> Groups "Clojure" group. >> To post to this group, send email to clo...@googlegroups.com<javascript:> >> Note that posts from new members are moderated - please be patient with >> your first post. >> To unsubscribe from this group, send email to >> clojure+u...@googlegroups.com <javascript:> >> For more options, visit this group at >> http://groups.google.com/group/clojure?hl=en > > -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en
