On Wed, 6 Aug 2025 20:15:08 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

>> When testing jtreg manual tests, some tests had unclear instructions. This 
>> PR is an attempt at updating these tests for clarity. 
>> 
>> `MouseDraggedOriginatedByScrollBarTest.java` works as expected when compared 
>> to native apps and outputs drag events even when the mouse pointer is 
>> dragged off of the scrollbar and window altogether. Events should still 
>> fire, but the previous instructions may make this confusing since it reads 
>> as if no events should be output to the textarea at all.
>> 
>> `TextAreaAppendScrollTest2.java` seems to not work when testing with the 
>> previous implementation of programmatically appending strings to the 
>> textarea. When I scroll down using the down arrow key, none of the text 
>> below would be visible when the textarea is scrolled down. However, it would 
>> show if I pressed `ENTER` to create a new line or manually modify the text 
>> in the textarea first. So instead, I have implemented the original reported 
>> approach to the test of adding a button to append a string to the textarea 
>> to test for automatic scrolling when the word is wrapped to a new line.
>
> test/jdk/java/awt/TextArea/TextAreaAppendScrollTest2.java line 71:
> 
>> 69:             coolStr.append("cool ");
>> 70:         }
>> 71:         area.append(coolStr.toString());
> 
> Is adding `12 * 15` _cools_ not enough?
> 
> The original instructions are pretty clear: if you see the exclamation marks, 
> then auto-scrolling works correctly; otherwise, it auto-scrolling doesn't 
> work as expected and the tester has to click **Fail**.

I was testing this on different OS's and on macOS the text is cut off and none 
of the text renders after a certain point.

This is what it looks like when I manually move the text cursor down to scroll 
the text area down a bit:
<img width="194" height="160" alt="Screenshot 2025-08-13 at 11 17 56 AM" 
src="https://github.com/user-attachments/assets/e3a10220-43c0-409b-8270-0f5dd3e134d5";
 />

I suppose this is a macOS bug. On linux (X11 and Wayland), this works fine, but 
the test does not start with the textarea showing the exclamation marks. 
Instead, it starts at the top. But, all of the text renders correctly when 
scrolled down. When I manually append another `cool` to the text area, the auto 
scroll and rendering of all the text works fine for all OS's.
<img width="191" height="138" alt="Screenshot 2025-08-13 at 11 23 48 AM" 
src="https://github.com/user-attachments/assets/92964ff1-792d-4c01-a12f-cef066cd7302";
 />

What I think I understand now is, there is most likely a macOS bug here and the 
test fails on linux. I'll revert the changes to this test. I think this also 
means I should ProblemList this test. I will, however, try fiddling with this 
test to see if I can get the programmatic appending to render on macOS and 
figure out the source of the issue. Maybe it will work with an added delay in 
the beginning or something of the sort.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26636#discussion_r2274279275

Reply via email to