On Tue, 5 Aug 2025 18:47:28 GMT, Phil Race <p...@openjdk.org> wrote:

>> When testing jtreg manual tests, some tests had unclear instructions. This 
>> PR is an attempt at updating these tests for clarity. 
>> 
>> `MouseDraggedOriginatedByScrollBarTest.java` works as expected when compared 
>> to native apps and outputs drag events even when the mouse pointer is 
>> dragged off of the scrollbar and window altogether. Events should still 
>> fire, but the previous instructions may make this confusing since it reads 
>> as if no events should be output to the textarea at all.
>> 
>> `TextAreaAppendScrollTest2.java` seems to not work when testing with the 
>> previous implementation of programmatically appending strings to the 
>> textarea. When I scroll down using the down arrow key, none of the text 
>> below would be visible when the textarea is scrolled down. However, it would 
>> show if I pressed `ENTER` to create a new line or manually modify the text 
>> in the textarea first. So instead, I have implemented the original reported 
>> approach to the test of adding a button to append a string to the textarea 
>> to test for automatic scrolling when the word is wrapped to a new line.
>
> test/jdk/java/awt/TextArea/TextAreaAppendScrollTest2.java line 42:
> 
>> 40:     TextArea area;
>> 41:     private static final String INSTRUCTIONS = """
>> 42:             Press the "Append \'cool\' button until you are able
> 
> Is this necessary even on X11 ? The test seems to have been written for that.

After testing and looking into the test on X11, Wayland, and macOS, I believe 
you're right. I can keep the original instructions. However, there are 
definitely issues with appending text and auto-scrolling in a textarea. Works 
fine when manually done with something like this button. Does not work when 
appending thru a for-loop as this test does (fails in various ways depending on 
OS).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26636#discussion_r2274282816

Reply via email to