On Tue, 26 Aug 2025 22:41:30 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:

>> When testing jtreg manual tests, some tests had unclear instructions. This 
>> PR is an attempt at updating these tests for clarity. 
>> 
>> `MouseDraggedOriginatedByScrollBarTest.java` works as expected when compared 
>> to native apps and outputs drag events even when the mouse pointer is 
>> dragged off of the scrollbar and window altogether. Events should still 
>> fire, but the previous instructions may make this confusing since it reads 
>> as if no events should be output to the textarea at all.
>> 
>> `TextAreaAppendScrollTest2.java` seems to not work when testing with the 
>> previous implementation of programmatically appending strings to the 
>> textarea. When I scroll down using the down arrow key, none of the text 
>> below would be visible when the textarea is scrolled down. However, it would 
>> show if I pressed `ENTER` to create a new line or manually modify the text 
>> in the textarea first. So instead, I have implemented the original reported 
>> approach to the test of adding a button to append a string to the textarea 
>> to test for automatic scrolling when the word is wrapped to a new line.
>
> Damon Nguyen has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Review comment update

> Now that there's only one test left in the PR, the subject doesn't correspond 
> to the content. You're no longer updating instructions for manual tests, 
> you're _automating one manual test_.

True. Definitely needs editing but theres a closed portion to this too.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26636#issuecomment-3231986048

Reply via email to