ioeric added inline comments.

================
Comment at: clangd/index/SymbolCollector.cpp:209
+  while (true) {
+    if (!Loc.isValid() || SM.isInMainFile(Loc))
+      break;
----------------
sammccall wrote:
> (as above, maybe want to include the main file for simplicity/symmetry)
Thanks! As you pointed out offline, we would need main file for correctness as 
well, as a main file could the exporting header.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D47187



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to