jkorous added inline comments.

================
Comment at: Sema/SemaDecl.cpp:4651-4653
+
+      DeclContext *OwnerScope = Owner->getRedeclContext();
+
----------------
vsapsai wrote:
> I think the code style favours avoiding excessive vertical whitespace and I 
> don't feel like this statement is semantically far enough from the 
> surrounding code to be separated from it. I haven't found a specific [LLVM 
> Coding Standards](https://llvm.org/docs/CodingStandards.html) rule, so in 
> this case it is my personal opinion and actual formatting decision is up to 
> you.
> 
> Other than that I have no other comments.
Strange, looks like phab lost my comment which basically was: "No problem, I 
see what you mean. Will remove those blank lines."


https://reviews.llvm.org/D45884



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to