lebedev.ri added inline comments.
================ Comment at: clang-doc/ClangDocBinary.cpp:72 + assert(Abbrevs.find(recordID) == Abbrevs.end() && + "Abbreviation already set."); + Abbrevs[recordID] = abbrevID; ---------------- juliehockett wrote: > lebedev.ri wrote: > > lebedev.ri wrote: > > > So it does not *set* the abbreviation, since it is not supposed to be > > > called if the abbreviation is already set, but it *adds* a unique > > > abbreviation. > > > I think it should be called `void AbbreviationMap::add(unsigned recordID, > > > unsigned abbrevID)` then > > This is marked as done, but the name is still the same, and no > > counter-comment was added, as far as i can see > It was changed to AbbreviationMap::add from AbbreviationMap::set, as you > suggested -- unless I missed something in your comment? Oh right, sorry, i was thinking about some other code it seems. https://reviews.llvm.org/D41102 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
