EricWF added a comment.

@rsmith. Sorry, you're right. I didn't notice that we already used 
`_LIBCPP_BUILDING_LIBRARY` in libc++abi.  I wasn't sure if `_BUILDING_LIBRARY` 
changed the linkage or of any symbols, or changed their explicit instantiation.
And, indeed, on Windows there's a problem with DLL import/export macros. I'll 
fix and cleanup the usage of `_BUILDING_LIBRARY` in the next couple days.


Repository:
  rL LLVM

https://reviews.llvm.org/D42987



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D42987: [... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D429... Marshall Clow via Phabricator via cfe-commits
    • [PATCH] D429... Eric Fiselier via Phabricator via cfe-commits
    • [PATCH] D429... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D429... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D429... Eric Fiselier via Phabricator via cfe-commits

Reply via email to