EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

I agree with Marshall. This should define 
`_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS` instead of 
`_LIBCPP_BUILDING_LIBRARY`. Other than that, this LGTM.


Repository:
  rCXXA libc++abi

https://reviews.llvm.org/D42987



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D42987: [... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D429... Marshall Clow via Phabricator via cfe-commits
    • [PATCH] D429... Eric Fiselier via Phabricator via cfe-commits
    • [PATCH] D429... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D429... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D429... Eric Fiselier via Phabricator via cfe-commits

Reply via email to