rsmith added a comment. I defined `_LIBCPP_BUILDING_LIBRARY` instead to match the existing code in libc++abi (stdlib_exception.cpp, stdlib_new_delete.cpp), which uses the `_BUILDING_LIBRARY` macro as a general way to say "give me all the symbols because I'm building the library". That seemed to match the semantics of this code better than a macro whose purpose is "I am writing user code that is still using this removed symbol".
But I don't really care. If you two prefer the other macro, that's fine with me :) (Would there be any interest in a patch that just unconditionally defines `_LIBCPP_BUILDING_LIBRARY` throughout the libc++abi compilation instead of this change?) Repository: rCXXA libc++abi https://reviews.llvm.org/D42987 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
