ruiu accepted this revision. ruiu added a comment. LGTM
================ Comment at: clang/lib/Driver/Driver.cpp:1283 + for (StringRef S : DiagnosticIDs::getDiagnosticFlags()) + if (StringRef(S).startswith(PassedFlags)) + SuggestedCompletions.push_back(S); ---------------- nit: StringRef(S) -> S as S is already a StringRef. https://reviews.llvm.org/D35447 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
