teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed.
It seems the code doesn't compile in clang because on your platform `std::vector` is implicitly included by some header, on clang+Arch however it isn`t (see the error at the end of https://teemperor.de/ccir/D35447). ================ Comment at: clang/lib/Driver/Driver.cpp:1279 + + for (std::string S : DiagnosticIDs::getDiagnosticFlags()) + if (StringRef(S).startswith(PassedFlags)) ---------------- ruiu wrote: > Let's avoid copy: std::string -> StringRef > Could you document why we had to do it this way and can't reuse the normal flags? Maybe even add a `TODO:` because it would be nice project for someone to refactor this into one data structure. https://reviews.llvm.org/D35447 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
