teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
I have a last request in my inline comment regarding the documentation,
otherwise this is good to go. Nice work!
================
Comment at: clang/include/clang/Basic/DiagnosticIDs.h:267
+ /// \brief Get the string of all diagnostic flags
+ static std::vector<std::string> getDiagnosticFlags();
----------------
Let's add an example to make it clear that we want to have the command line
flags here, something like this:
```
/// \brief Get the list of all diagnostic flags.
/// \returns A list of all diagnostics flags as they would be written in a
command line invocation
/// including their `no-` variants. For example: `{"-Wempty-body",
"-Wno-empty-body", ...}`
```
https://reviews.llvm.org/D35447
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
