dkrupp added inline comments. ================ Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1011 @@ +1010,3 @@ + // containing the elements. + Region = (State->getSVal(NE, LCtx)) + .getAsRegion() ---------------- MemRegion has now method called castAs<>, only getAs<>, so I stayed with it.
================ Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1020 @@ +1019,3 @@ + } + assert(Region); + ---------------- I changed the type of Region to SubRegion, hope this is clearer this way. ================ Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1043 @@ -988,3 +1042,3 @@ void MallocChecker::checkPreStmt(const CXXDeleteExpr *DE, CheckerContext &C) const { ---------------- now inlined https://reviews.llvm.org/D24307 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits