dkrupp added inline comments. ================ Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1003 @@ +1002,3 @@ +// +ProgramStateRef MallocChecker::addExtentSize(CheckerContext &C, + const CXXNewExpr *NE, ---------------- xazax.hun wrote: > zaks.anna wrote: > > I am not sure this code belongs to the malloc checker since it only > > supports the array bounds checker. Is there a reason it's not part of that > > checker? > I think it is part of the malloc checker because it already does something > very very similar to malloc, see the MallocMemAux function. So in fact, for > the array bounds checker to work properly, the malloc checker should be > turned on. Extent size is used by ArrayBoundChecker, ArrayBoundCheckerV2 and CStringChecker checkers currently. New expression in case of simple allocations (0 allocation) was already handled in Malloc checker , that's why I implemented it there. But I agree it feels odd that one has to switch on unix.Malloc checker to get the size of new allocated heap regions. Should I move this to ArrayBoundChecker or ArrayBoundCheckerV2?
https://reviews.llvm.org/D24307 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
