tejohnson added inline comments.
================ Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:277 +static cl::opt<bool> AlwaysAllowSimplifyCFGSpeculation( + "always-allow-simplify-cfg-speculation", cl::init(false), cl::Hidden, ---------------- aeubanks wrote: > can we just drop the flag and make this change? Ok, I will remove. ================ Comment at: llvm/test/Transforms/SimplifyCFG/fold-branch-to-common-dest.ll:3 ; RUN: opt < %s -S -passes=simplifycfg -simplifycfg-require-and-preserve-domtree=1 -bonus-inst-threshold=10 | FileCheck %s +; RUN: opt < %s -S -passes='simplifycfg<no-speculate-blocks>' -simplifycfg-require-and-preserve-domtree=1 -bonus-inst-threshold=10 | FileCheck %s --check-prefix=NOSPECULATE ---------------- aeubanks wrote: > these checks won't work for a `update_test_checks.py` test. should add tests > like the one added in https://reviews.llvm.org/D153391 Can you clarify - are you saying remove the changes from this test and add a new test for this change like llvm/test/Transforms/SimplifyCFG/speculate-blocks.ll, or change the checks here? ================ Comment at: llvm/test/Transforms/SimplifyCFG/pipeline-delay-speculation-pgo.ll:1 +;; Test that the pipelines delay simplify CFG speculation until after +;; pgo annotation. ---------------- aeubanks wrote: > do you have a phase ordering test instead? Can you clarify what you are referring to? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155997/new/ https://reviews.llvm.org/D155997 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
