aeubanks added a comment. the pipeline change and simplifycfg change should be split into two changes
================ Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:277 +static cl::opt<bool> AlwaysAllowSimplifyCFGSpeculation( + "always-allow-simplify-cfg-speculation", cl::init(false), cl::Hidden, ---------------- can we just drop the flag and make this change? ================ Comment at: llvm/test/Transforms/SimplifyCFG/fold-branch-to-common-dest.ll:3 ; RUN: opt < %s -S -passes=simplifycfg -simplifycfg-require-and-preserve-domtree=1 -bonus-inst-threshold=10 | FileCheck %s +; RUN: opt < %s -S -passes='simplifycfg<no-speculate-blocks>' -simplifycfg-require-and-preserve-domtree=1 -bonus-inst-threshold=10 | FileCheck %s --check-prefix=NOSPECULATE ---------------- these checks won't work for a `update_test_checks.py` test. should add tests like the one added in https://reviews.llvm.org/D153391 ================ Comment at: llvm/test/Transforms/SimplifyCFG/pipeline-delay-speculation-pgo.ll:1 +;; Test that the pipelines delay simplify CFG speculation until after +;; pgo annotation. ---------------- do you have a phase ordering test instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155997/new/ https://reviews.llvm.org/D155997 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
