aeubanks added a comment. can we try not gating this on PGO as suggested? minimizing differences between pipelines is nice, and as mentioned it'll help with other cases
================ Comment at: llvm/test/Transforms/PhaseOrdering/simplifycfg-speculate-blocks.ll:1 +;; Check that SimplifyCFG does not attempt speculation until after PGO is +;; annotated in the IR, and then does not perform it when unprofitable. ---------------- nikic wrote: > aeubanks wrote: > > hmm typically these phase ordering tests use > > `llvm/utils/update_test_checks.py`, but that doesn't support the > > llvm-profdata RUN line. I think a non-update_test_checks test is probably > > fine for this, @nikic does that make sense? > > > > > I thought UTC supports unrecognized commands (by just executing them)... If > not, a non-UTC test is fine. `update_test_checks.py` doesn't handle `%t` (maybe that's an improvement we could make to the script) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155997/new/ https://reviews.llvm.org/D155997 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
