FreddyYe added inline comments.

================
Comment at: llvm/lib/Target/X86/X86.td:1082
                                                   FeaturePREFETCHI,
-                                                  FeatureSHA512,
                                                   FeatureAMXCOMPLEX];
   list<SubtargetFeature> GNRFeatures =
----------------
FreddyYe wrote:
> RKSimon wrote:
> > RKSimon wrote:
> > > If this was incorrect it needs to be removed in its own patch
> > Doesn't the FeatureAMXCOMPLEX need to be on GNRDAdditionalFeatures and 
> > removed from GNRAdditionalFeatures?
> Right. Fixed in 
> https://github.com/llvm/llvm-project/commit/5533fc10219747d1b312f8057edfb10d4d0fcd77
Sorry for mess here. Addressed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155798/new/

https://reviews.llvm.org/D155798

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to