RKSimon added inline comments.
================
Comment at: llvm/lib/Target/X86/X86.td:1082
FeaturePREFETCHI,
- FeatureSHA512,
FeatureAMXCOMPLEX];
----------------
If this was incorrect it needs to be removed in its own patch
================
Comment at: llvm/lib/Target/X86/X86.td:1082
FeaturePREFETCHI,
- FeatureSHA512,
FeatureAMXCOMPLEX];
list<SubtargetFeature> GNRFeatures =
----------------
RKSimon wrote:
> If this was incorrect it needs to be removed in its own patch
Doesn't the FeatureAMXCOMPLEX need to be on GNRDAdditionalFeatures and removed
from GNRAdditionalFeatures?
================
Comment at: llvm/lib/Target/X86/X86.td:1090
+ list<SubtargetFeature> GNRDFeatures =
+ !listconcat(SPRFeatures, GNRDAdditionalFeatures);
+
----------------
Why not concat with GNRAdditionalFeatures ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155798/new/
https://reviews.llvm.org/D155798
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
