FreddyYe marked 2 inline comments as done. FreddyYe added inline comments.
================ Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1925 // CHECK_GNR_M64: #define __AMX_BF16__ 1 -// CHECK_GNR_M64: #define __AMX_COMPLEX__ 1 +// CHECK_GNR_M64-NOT: #define __AMX_COMPLEX__ 1 +// CHECK_GNRD_M64: #define __AMX_COMPLEX__ 1 ---------------- pengfei wrote: > FreddyYe wrote: > > RKSimon wrote: > > > Won't this fail on the graniterapids-d run? > > Whops, I didn't realize this problem before! But it indeed doesn't fail. > > Need to figure out why... > I'm guessing when using multi prefixes, it will try to match with the second > one if the first failed. It's common and easy to understand for positive > check but a bit confusing for negative one. I did some experiments and arrived at same guessing. It indeed worked here for graniterapids-d and checked each `#define` for it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
