RKSimon added a comment. In D151696#4458751 <https://reviews.llvm.org/D151696#4458751>, @FreddyYe wrote:
> In D151696#4458443 <https://reviews.llvm.org/D151696#4458443>, @pengfei wrote: > >> It looks to me the failed unit tests might be related to this patch, please >> take a look. > > This is due to FeatureCMOV adding. Should I split into another review? Yes, it looks like it would be best to split off and commit some of the fixes (cmov / the isa changes causing the attr-cpuspecific.c diffs etc.) first, before this refactor patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
