RKSimon added inline comments.
================
Comment at: clang/test/CodeGen/attr-cpuspecific.c:47
// LINUX: %[[FEAT_INIT:.+]] = load i32, ptr getelementptr inbounds ({ i32,
i32, i32, [1 x i32] }, ptr @__cpu_model, i32 0, i32 3, i32 0), align 4
-// LINUX: %[[FEAT_JOIN:.+]] = and i32 %[[FEAT_INIT]], 1023
-// LINUX: %[[FEAT_CHECK:.+]] = icmp eq i32 %[[FEAT_JOIN]], 1023
+// LINUX: %[[FEAT_JOIN:.+]] = and i32 %[[FEAT_INIT]], 525311
+// LINUX: %[[FEAT_CHECK:.+]] = icmp eq i32 %[[FEAT_JOIN]], 525311
----------------
FreddyYe wrote:
> RKSimon wrote:
> > FreddyYe wrote:
> > > This value change is because the feature list of ivybridge described in
> > > X86TargetParser.def before missed feature "pclmul".
> > Pull out an ivybridge fix into its own patch?
> Emmm. Seems like a good idea. How about I change these two CPU's old feature
> list only? Since the successors of them will also have this issue, but no
> tests influenced.
Sure, a single patch with multiple cpus' fixups is fine
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151696/new/
https://reviews.llvm.org/D151696
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
