sammccall marked 15 inline comments as done.
sammccall added inline comments.
================
Comment at: clang/lib/Analysis/FlowSensitive/CMakeLists.txt:22
+add_custom_command(OUTPUT HTMLLogger.inc
+ COMMAND "${Python3_EXECUTABLE}" bundle_resources.py
+ ${CMAKE_CURRENT_BINARY_DIR}/HTMLLogger.inc
----------------
gribozavr2 wrote:
> Is this the right location for the Python script? Aren't they normally under
> `llvm-project.git/clang/utils`?
I've moved it, though honestly I have no idea if that's the right place :-)
Clang/utils has lots of tools to invoke by hand, test helpers, the sources for
clang-tablegen, and exactly one build-time python script that I could find.
Python scripts that are part of the build graph seem to usually live somewhere
under the dir that uses them (libclang/linker-script-to-export-list.py,
llvm-shlib/gen-msvc-exports.py, libclc/generic/lib/gen_convert.py,
Tooling/DumpTool/generate_cxx_src_locs.py), but not always.
OTOH, this is fairly generic (there's also a copy under
clang-tools-extra/pseudo) so probably makes sense to have somewhere sharable.
================
Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.js:128
+ // hex values to subtract from fff to get a base color
+ options = [0x001, 0x010, 0x100, 0x011, 0x101, 0x110, 0x111];
+ function color(hex) {
----------------
gribozavr2 wrote:
> Or was the order intentional?
Somehow ordering by {number of set bits, lexicographic} makes sense in my head
but I've changed it because I can't explain why :-)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146591/new/
https://reviews.llvm.org/D146591
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
