gribozavr2 added inline comments.
================ Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.html:19 +<header>Function</header> +<div id="code"></div> +<div id="cfg"></div> ---------------- sammccall wrote: > gribozavr2 wrote: > > Could you add the file name and line number of the start location of the > > function? > > > > It might be helpful not only for the reader (to confirm that they are > > debugging the right thing), but also when finding the right html file using > > grep. > Added filename to the top of the code, and line numbers to each line. > (This seems nice for display, but doesn't allow you to grep for `foo.cpp:42` > - is that critical?) Imagine you're debugging an analysis on a relatively big file. How would you find the html file that corresponds to a function where the analysis is misbehaving? What if the function has a relatively common name? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146591/new/ https://reviews.llvm.org/D146591 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
