sammccall added a comment. I think there's a clear benefit, but my feeling is it's outweighed by the costs, which are fairly high given lack of any automation/tests. If clangd contributors should maintain this, how should contributors/reviewers know whether changes are correct? If they needn't maintain it, then having it on a third-party site seems appropriate. Maybe a `/contrib/` directory is a useful compromise?
This is definitely informed by my biases: I have to make/review changes that touch config, don't have a good understanding of JSON-schema, and I don't use VSCode. --- One practical question: AIUI the main point of having this is so it can be provided to the VSCode YAML extension so it understands .clangd files. How does this work mechanically? Does it need to be part of the vscode-clangd repo instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140462/new/ https://reviews.llvm.org/D140462 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
