nridge added a subscriber: sammccall.
nridge added a comment.
Thanks, this is pretty neat!
cc @sammccall as a heads up, just to make sure you're cool with having this
in-tree
================
Comment at: clang-tools-extra/clangd/schema/config.json:48
+ "description": "Directory to search for compilation database
(compile_commands.json etc).",
+ "type": "string"
+ },
----------------
Technically `string` OR `enum [ "Ancestors", "None" ]` would be more accurate
Not sure if it's worth specifying that... from a validation point of view,
`string` is a superset of the other one, but maybe some people will look at the
schema for documentation, in which it could be useful to have those "keywords"
listed?
================
Comment at: clang-tools-extra/clangd/schema/config.json:72
+ "type": "object",
+ "oneOf": [
+ {
----------------
I don't think this is quite right:
* If `File` is specified, `Server` and `MountPoint` should not be
* If `Server` is specified, `MountPoint` can optionally be specified but
`File` should not be
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140462/new/
https://reviews.llvm.org/D140462
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
