HaoyuZhang added a comment.
Thanks for the comments. The modifications have been finished. PTAL~
================
Comment at: clang/include/clang/Driver/Options.td:1253
+ Flags<[NoXarchOption, CC1Option]>, Group<f_Group>,
+ HelpText<"Use profi to infer block and edge counts.">;
def fno_profile_sample_accurate : Flag<["-"], "fno-profile-sample-accurate">,
----------------
hans wrote:
> A user who reads the help message might reasonably ask "what's profi". Can
> you please add some documentation about it? It would also be nice with a
> DocBrief (see e.g. -fprofile-sample-accurate above).
Hi Hans, thank you for the comments. The DocBrief may be a good choice. I have
added it in new commit.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5763
+ // Enable profi in frontend and forward to LLVM invocation
+ if (Args.hasArg(options::OPT_fsample_profile_use_profi)) {
----------------
hans wrote:
> Perhaps consider skipping this comment, the code is clear enough.
It has been deleted.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136846/new/
https://reviews.llvm.org/D136846
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
