royjacobson marked an inline comment as done. royjacobson added inline comments.
================ Comment at: clang/test/SemaCXX/specialization-diagnose-crash.cpp:2 +// RUN: %clang_cc1 -fsyntax-only %s -verify +// expected-no-diagnostics +// This is a reduction of GH57370 and GH58028, originally appearing ---------------- shafik wrote: > Shouldn't we see a diagnostic in order to exercise the code that is being > fixed? Since this fixes an ICE I'm not sure we actually need to, but I modified it a bit so we have assurance that the specialization code runs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134885/new/ https://reviews.llvm.org/D134885 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
