shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land.
LFTM besides the comment about the test. ================ Comment at: clang/test/SemaCXX/specialization-diagnose-crash.cpp:2 +// RUN: %clang_cc1 -fsyntax-only %s -verify +// expected-no-diagnostics +// This is a reduction of GH57370 and GH58028, originally appearing ---------------- Shouldn't we see a diagnostic in order to exercise the code that is being fixed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134885/new/ https://reviews.llvm.org/D134885 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
